refactor: do not guess if changelog format is provided, make function private#1471
Merged
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom Jun 8, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1471 +/- ##
==========================================
Coverage 97.87% 97.87%
==========================================
Files 57 57
Lines 2677 2678 +1
==========================================
+ Hits 2620 2621 +1
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
May 31, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
mostly good, left some nitpicks
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
bearomorphism
changed the title
Member
|
we probably should make the commit message itself easy to read instead of the github pr title as we're not squashing commits |
Lee-W
approved these changes
Jun 8, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
mostly good, but will need your help to resolve conflict and reword commit message
Lee-W
added
pr-status: ready-to-merge
Collaborator
Author
|
rebased and reworded |
Lee-W
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context